mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-01-21 06:45:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

test/link/elf: do not check for $thunk in thunks tests for now

Browse Source 
Andrew and I have discovered that on Linux max peak rss value
is taken to be `max(build_runner, test_suite)` and since the thunks
test emit a huge binary, we will easily exceed the declared maximum
for any of the test suites. This can be worked around for now by not
checking for $thunk symbols in this test since it doesn't really
yield any additional information; however ideally we would implement
per-thread local temp arena that can be freed.
This commit is contained in:
Jakub Konka 2024-03-12 20:21:48 +01:00
parent 55c085b893
commit 7ba2453b8e
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/link/elf.zig
View File

@ -2698,12 +2698,6 @@ fn testThunks(b: *Build, opts: Options) *Step {
run.expectStdOutEqual("bar=42, foo=0, foobar=42");
run.expectExitCode(0);
test_step.dependOn(&run.step);
const check = exe.checkObject();
check.max_bytes = std.math.maxInt(u32);
check.checkInSymtab();
check.checkContains("__libc_start_main$thunk");
test_step.dependOn(&check.step);
}
{
@ -2714,12 +2708,6 @@ fn testThunks(b: *Build, opts: Options) *Step {
run.expectStdOutEqual("bar=42, foo=0, foobar=42");
run.expectExitCode(0);
test_step.dependOn(&run.step);
const check = exe.checkObject();
check.max_bytes = std.math.maxInt(u32);
check.checkInSymtab();
check.checkContains("__libc_start_main$thunk");
test_step.dependOn(&check.step);
}
return test_step;