From 7ba2453b8ec56ccacfccc466183e1aaafbd5210e Mon Sep 17 00:00:00 2001 From: Jakub Konka Date: Tue, 12 Mar 2024 20:21:48 +0100 Subject: [PATCH] test/link/elf: do not check for $thunk in thunks tests for now Andrew and I have discovered that on Linux max peak rss value is taken to be `max(build_runner, test_suite)` and since the thunks test emit a huge binary, we will easily exceed the declared maximum for any of the test suites. This can be worked around for now by not checking for $thunk symbols in this test since it doesn't really yield any additional information; however ideally we would implement per-thread local temp arena that can be freed. --- test/link/elf.zig | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/test/link/elf.zig b/test/link/elf.zig index fd6af3160f..d018d042e3 100644 --- a/test/link/elf.zig +++ b/test/link/elf.zig @@ -2698,12 +2698,6 @@ fn testThunks(b: *Build, opts: Options) *Step { run.expectStdOutEqual("bar=42, foo=0, foobar=42"); run.expectExitCode(0); test_step.dependOn(&run.step); - - const check = exe.checkObject(); - check.max_bytes = std.math.maxInt(u32); - check.checkInSymtab(); - check.checkContains("__libc_start_main$thunk"); - test_step.dependOn(&check.step); } { @@ -2714,12 +2708,6 @@ fn testThunks(b: *Build, opts: Options) *Step { run.expectStdOutEqual("bar=42, foo=0, foobar=42"); run.expectExitCode(0); test_step.dependOn(&run.step); - - const check = exe.checkObject(); - check.max_bytes = std.math.maxInt(u32); - check.checkInSymtab(); - check.checkContains("__libc_start_main$thunk"); - test_step.dependOn(&check.step); } return test_step;