mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-12 20:37:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

stage2: is_non_error always returns comptime true for empty error set

Browse Source
This commit is contained in:
Mitchell Hashimoto 2022-03-11 11:53:01 -08:00 committed by Andrew Kelley
parent 797f4db227
commit fca51c81bc
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Sema.zig
View File

@ -18144,6 +18144,15 @@ fn analyzeIsNonErr(
if (ot != .ErrorSet and ot != .ErrorUnion) return Air.Inst.Ref.bool_true;
if (ot == .ErrorSet) return Air.Inst.Ref.bool_false;
assert(ot == .ErrorUnion);
// exception if the error union error set is known to be empty,
// we allow the comparison but always make it comptime known.
const set_ty = operand_ty.errorUnionSet();
switch (set_ty.tag()) {
.anyerror, .error_set_inferred => {},
else => if (set_ty.errorSetNames().len == 0) return Air.Inst.Ref.bool_true,
}
const result_ty = Type.bool;
if (try sema.resolveMaybeUndefVal(block, src, operand)) |err_union| {
if (err_union.isUndef()) {

6
test/behavior/error.zig
View File

@ -215,7 +215,11 @@ fn testExplicitErrorSetCast(set1: Set1) !void {
}
test "comptime test error for empty error set" {
if (builtin.zig_backend != .stage1) return error.SkipZigTest; // TODO
if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
try testComptimeTestErrorEmptySet(1234);
comptime try testComptimeTestErrorEmptySet(1234);