mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-06 14:23:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

llvm: optional slices cannot be passed in parts when they allowzero

Browse Source 
Closes #18428
This commit is contained in:
Veikka Tuominen 2024-01-08 01:23:17 +02:00
parent 3f6e651d5a
commit faeb0ef032
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/codegen/llvm.zig
View File

@ -11197,7 +11197,9 @@ const ParamTypeIterator = struct {
.Unspecified, .Inline => { .Unspecified, .Inline => {
it.zig_index += 1; it.zig_index += 1;
it.llvm_index += 1; it.llvm_index += 1;
if (ty.isSlice(mod) or (ty.zigTypeTag(mod) == .Optional and ty.optionalChild(mod).isSlice(mod))) { if (ty.isSlice(mod) or
(ty.zigTypeTag(mod) == .Optional and ty.optionalChild(mod).isSlice(mod) and !ty.ptrAllowsZero(mod)))
{
it.llvm_index += 1; it.llvm_index += 1;
return .slice; return .slice;
} else if (isByRef(ty, mod)) { } else if (isByRef(ty, mod)) {

17
test/behavior/optional.zig
View File

@ -448,6 +448,23 @@ test "Optional slice size is optimized" {
try expectEqualStrings(a.?, "hello"); try expectEqualStrings(a.?, "hello");
} }
test "Optional slice passed to function" {
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
const S = struct {
fn foo(a: ?[]const u8) !void {
try std.testing.expectEqualStrings(a.?, "foo");
}
fn bar(a: ?[]allowzero const u8) !void {
try std.testing.expectEqualStrings(@ptrCast(a.?), "bar");
}
};
try S.foo("foo");
try S.bar("bar");
}
test "peer type resolution in nested if expressions" { test "peer type resolution in nested if expressions" {
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;