mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-21 16:54:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

stage2: sparcv9: Fix stack space accounting

Browse Source
This commit is contained in:
Koakuma 2022-04-21 06:02:53 +07:00 committed by Jakub Konka
parent e03ec51b4b
commit f6bf3dd78c
2 changed files with 37 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/arch/sparcv9/CodeGen.zig
View File

@ -340,16 +340,15 @@ fn gen(self: *Self) !void {
if (cc != .Naked) {
// TODO Finish function prologue and epilogue for sparcv9.
// TODO Backpatch stack offset
// save %sp, -176, %sp
_ = try self.addInst(.{
// save %sp, stack_save_area, %sp
const save_inst = try self.addInst(.{
.tag = .save,
.data = .{
.arithmetic_3op = .{
.is_imm = true,
.rd = .sp,
.rs1 = .sp,
.rs2_or_imm = .{ .imm = -176 },
.rs2_or_imm = .{ .imm = -abi.stack_save_area },
},
},
});
@ -382,6 +381,28 @@ fn gen(self: *Self) !void {
return self.fail("TODO add branches in sparcv9", .{});
}
// Backpatch stack offset
const total_stack_size = self.max_end_stack + abi.stack_save_area; // TODO + self.saved_regs_stack_space;
const stack_size = mem.alignForwardGeneric(u32, total_stack_size, self.stack_align);
if (math.cast(i13, stack_size)) |size| {
self.mir_instructions.set(save_inst, .{
.tag = .save,
.data = .{
.arithmetic_3op = .{
.is_imm = true,
.rd = .sp,
.rs1 = .sp,
.rs2_or_imm = .{ .imm = -size },
},
},
});
} else |_| {
// TODO for large stacks, replace the prologue with:
// setx stack_size, %g1
// save %sp, %g1, %sp
return self.fail("TODO SPARCv9: allow larger stacks", .{});
}
// return %i7 + 8
_ = try self.addInst(.{
.tag = .@"return",
@ -1367,8 +1388,8 @@ fn genSetReg(self: *Self, ty: Type, reg: Register, mcv: MCValue) InnerError!void
try self.genLoad(reg, reg, i13, 0, ty.abiSize(self.target.*));
},
.stack_offset => |off| {
const biased_offset = off + abi.stack_bias;
const simm13 = math.cast(i13, biased_offset) catch
const real_offset = off + abi.stack_bias + abi.stack_save_area;
const simm13 = math.cast(i13, real_offset) catch
return self.fail("TODO larger stack offsets", .{});
try self.genLoad(reg, .sp, i13, simm13, ty.abiSize(self.target.*));
},
@ -1399,8 +1420,8 @@ fn genSetStack(self: *Self, ty: Type, stack_offset: u32, mcv: MCValue) InnerErro
return self.genSetStack(ty, stack_offset, MCValue{ .register = reg });
},
.register => |reg| {
const biased_offset = stack_offset + abi.stack_bias;
const simm13 = math.cast(i13, biased_offset) catch
const real_offset = stack_offset + abi.stack_bias + abi.stack_save_area;
const simm13 = math.cast(i13, real_offset) catch
return self.fail("TODO larger stack offsets", .{});
return self.genStore(reg, .sp, i13, simm13, abi_size);
},

9
src/arch/sparcv9/abi.zig
View File

@ -1,11 +1,18 @@
const bits = @import("bits.zig");
const Register = bits.Register;
// SPARCv9 stack constants.
// See: Registers and the Stack Frame, page 3P-8, SCD 2.4.1.
// On SPARCv9, %sp points to top of stack + stack bias,
// and %fp points to top of previous frame + stack bias.
// See: Registers and the Stack Frame, page 3P-8, SCD 2.4.1.
pub const stack_bias = 2047;
// The first 176 bytes of the stack is reserved for register saving purposes.
// SPARCv9 requires to reserve space in the stack for the first six arguments,
// even though they are usually passed in registers.
pub const stack_save_area = 176;
// There are no callee-preserved registers since the windowing
// mechanism already takes care of them.
// We still need to preserve %o0-%o5, %g1, %g4, and %g5 before calling