From f69305f865c346ffb2a00403efd0768f8bbdd20b Mon Sep 17 00:00:00 2001 From: Ersikan Date: Sat, 13 Mar 2021 12:00:06 +0100 Subject: [PATCH] stage2: Warn when using --debug-log without logging enabled A warning is emitted when using the debug option --debug-log when the compiler was not compiled using the build option -Dlog. Additionnaly, the scopes are not added to log_scopes as they have no effect. --- src/main.zig | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main.zig b/src/main.zig index 011b9edf76..bc4f209b45 100644 --- a/src/main.zig +++ b/src/main.zig @@ -841,7 +841,11 @@ fn buildOutputType( } else if (mem.eql(u8, arg, "--debug-log")) { if (i + 1 >= args.len) fatal("expected parameter after {s}", .{arg}); i += 1; - try log_scopes.append(gpa, args[i]); + if (!build_options.enable_logging) { + std.log.warn("Zig was compiled without logging enabled (-Dlog). --debug-log has no effect.", .{}); + } else { + try log_scopes.append(gpa, args[i]); + } } else if (mem.eql(u8, arg, "-fcompiler-rt")) { want_compiler_rt = true; } else if (mem.eql(u8, arg, "-fno-compiler-rt")) {