From f4a9e0530a065f637f1a7fba95b163597bd88410 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Sun, 20 Jun 2021 20:55:33 -0700 Subject: [PATCH] AstGen: convert a TODO comment to an issue See #363 --- src/AstGen.zig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/AstGen.zig b/src/AstGen.zig index ec6f9518b1..e08d650936 100644 --- a/src/AstGen.zig +++ b/src/AstGen.zig @@ -5192,9 +5192,10 @@ fn whileExpr( try loop_scope.instructions.append(astgen.gpa, cond_block); try continue_scope.setBlockBody(cond_block); - // TODO avoid emitting the continue expr when there + // This code could be improved to avoid emitting the continue expr when there // are no jumps to it. This happens when the last statement of a while body is noreturn // and there are no `continue` statements. + // Tracking issue: https://github.com/ziglang/zig/issues/9185 if (while_full.ast.cont_expr != 0) { _ = try expr(&loop_scope, &loop_scope.base, .{ .ty = .void_type }, while_full.ast.cont_expr); }