mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-11 16:53:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

CBE: fix bad local reuse for volatile memset

Browse Source
This commit is contained in:
Jacob Young 2022-12-04 23:50:28 -05:00 committed by Andrew Kelley
parent ce4e5fee63
commit f421efbcc1
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/codegen/c.zig
View File

@ -5935,16 +5935,15 @@ fn airMemset(f: *Function, inst: Air.Inst.Index) !CValue {
const dest_ptr = try f.resolveInst(pl_op.operand); const dest_ptr = try f.resolveInst(pl_op.operand);
const value = try f.resolveInst(extra.lhs); const value = try f.resolveInst(extra.lhs);
const len = try f.resolveInst(extra.rhs); const len = try f.resolveInst(extra.rhs);
try reap(f, inst, &.{ pl_op.operand, extra.lhs, extra.rhs });
const writer = f.object.writer(); const writer = f.object.writer();
if (dest_ty.isVolatilePtr()) { if (dest_ty.isVolatilePtr()) {
var u8_ptr_pl = dest_ty.ptrInfo(); var u8_ptr_pl = dest_ty.ptrInfo();
u8_ptr_pl.data.pointee_type = Type.u8; u8_ptr_pl.data.pointee_type = Type.u8;
const u8_ptr_ty = Type.initPayload(&u8_ptr_pl.base); const u8_ptr_ty = Type.initPayload(&u8_ptr_pl.base);
const index = try f.allocLocal(inst, Type.usize);
try writer.writeAll("for ("); try writer.writeAll("for (");
const index = try f.allocLocal(inst, Type.usize);
try f.writeCValue(writer, index, .Other); try f.writeCValue(writer, index, .Other);
try writer.writeAll(" = "); try writer.writeAll(" = ");
try f.object.dg.renderValue(writer, Type.usize, Value.zero, .Initializer); try f.object.dg.renderValue(writer, Type.usize, Value.zero, .Initializer);
@ -5966,11 +5965,13 @@ fn airMemset(f: *Function, inst: Air.Inst.Index) !CValue {
try f.writeCValue(writer, value, .FunctionArgument); try f.writeCValue(writer, value, .FunctionArgument);
try writer.writeAll(";\n"); try writer.writeAll(";\n");
try reap(f, inst, &.{ pl_op.operand, extra.lhs, extra.rhs });
try freeLocal(f, inst, index.local, 0); try freeLocal(f, inst, index.local, 0);
return CValue.none; return CValue.none;
} }
try reap(f, inst, &.{ pl_op.operand, extra.lhs, extra.rhs });
try writer.writeAll("memset("); try writer.writeAll("memset(");
try f.writeCValue(writer, dest_ptr, .FunctionArgument); try f.writeCValue(writer, dest_ptr, .FunctionArgument);
try writer.writeAll(", "); try writer.writeAll(", ");