From f33af7af40faccc05f66417f1ba5caa4eb158769 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Mon, 27 Feb 2023 20:42:13 -0700 Subject: [PATCH] delete a subtly incorrect Haiku collectOutput implementation It's not OK to half-ass this function. Please implement it correctly, or not at all. --- lib/std/child_process.zig | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/std/child_process.zig b/lib/std/child_process.zig index c3bd53b880..55e375b93b 100644 --- a/lib/std/child_process.zig +++ b/lib/std/child_process.zig @@ -210,13 +210,7 @@ pub const ChildProcess = struct { ) !void { debug.assert(child.stdout_behavior == .Pipe); debug.assert(child.stderr_behavior == .Pipe); - if (builtin.os.tag == .haiku) { - const stdout_in = child.stdout.?.reader(); - const stderr_in = child.stderr.?.reader(); - - try stdout_in.readAllArrayList(stdout, max_output_bytes); - try stderr_in.readAllArrayList(stderr, max_output_bytes); - } else if (builtin.os.tag == .windows) { + if (builtin.os.tag == .windows) { try collectOutputWindows(child, stdout, stderr, max_output_bytes); } else { try collectOutputPosix(child, stdout, stderr, max_output_bytes);