Link the issue in doc comment

This commit is contained in:
Rocknest 2020-02-01 13:15:49 +02:00
parent a56183197d
commit f30feab1b9

View File

@ -378,6 +378,7 @@ pub fn printSourceAtAddress(debug_info: *DebugInfo, out_stream: var, address: us
return noasync printSourceAtAddressPosix(debug_info, out_stream, address, tty_config); return noasync printSourceAtAddressPosix(debug_info, out_stream, address, tty_config);
} }
/// TODO resources https://github.com/ziglang/zig/issues/4353
fn printSourceAtAddressWindows( fn printSourceAtAddressWindows(
di: *DebugInfo, di: *DebugInfo,
out_stream: var, out_stream: var,
@ -604,6 +605,7 @@ pub const TTY = struct {
}; };
}; };
/// TODO resources https://github.com/ziglang/zig/issues/4353
fn populateModule(di: *DebugInfo, mod: *Module) !void { fn populateModule(di: *DebugInfo, mod: *Module) !void {
if (mod.populated) if (mod.populated)
return; return;
@ -755,6 +757,7 @@ pub const OpenSelfDebugInfoError = error{
UnsupportedOperatingSystem, UnsupportedOperatingSystem,
}; };
/// TODO resources https://github.com/ziglang/zig/issues/4353
/// TODO once https://github.com/ziglang/zig/issues/3157 is fully implemented, /// TODO once https://github.com/ziglang/zig/issues/3157 is fully implemented,
/// make this `noasync fn` and remove the individual noasync calls. /// make this `noasync fn` and remove the individual noasync calls.
pub fn openSelfDebugInfo(allocator: *mem.Allocator) !DebugInfo { pub fn openSelfDebugInfo(allocator: *mem.Allocator) !DebugInfo {
@ -963,6 +966,7 @@ pub fn openDwarfDebugInfo(di: *DwarfInfo, allocator: *mem.Allocator) !void {
try di.scanAllCompileUnits(); try di.scanAllCompileUnits();
} }
/// TODO resources https://github.com/ziglang/zig/issues/4353
pub fn openElfDebugInfo( pub fn openElfDebugInfo(
allocator: *mem.Allocator, allocator: *mem.Allocator,
data: []u8, data: []u8,
@ -1001,6 +1005,7 @@ pub fn openElfDebugInfo(
return di; return di;
} }
/// TODO resources https://github.com/ziglang/zig/issues/4353
fn openSelfDebugInfoPosix(allocator: *mem.Allocator) !DwarfInfo { fn openSelfDebugInfoPosix(allocator: *mem.Allocator) !DwarfInfo {
var exe_file = try fs.openSelfExe(); var exe_file = try fs.openSelfExe();
errdefer exe_file.close(); errdefer exe_file.close();
@ -1020,6 +1025,7 @@ fn openSelfDebugInfoPosix(allocator: *mem.Allocator) !DwarfInfo {
return openElfDebugInfo(allocator, exe_mmap); return openElfDebugInfo(allocator, exe_mmap);
} }
/// TODO resources https://github.com/ziglang/zig/issues/4353
fn openSelfDebugInfoMacOs(allocator: *mem.Allocator) !DebugInfo { fn openSelfDebugInfoMacOs(allocator: *mem.Allocator) !DebugInfo {
const hdr = &std.c._mh_execute_header; const hdr = &std.c._mh_execute_header;
assert(hdr.magic == std.macho.MH_MAGIC_64); assert(hdr.magic == std.macho.MH_MAGIC_64);
@ -2072,6 +2078,7 @@ fn getAbbrevTableEntry(abbrev_table: *const AbbrevTable, abbrev_code: u64) ?*con
return null; return null;
} }
/// TODO resources https://github.com/ziglang/zig/issues/4353
fn getLineNumberInfoMacOs(di: *DebugInfo, symbol: MachoSymbol, address: usize) !LineInfo { fn getLineNumberInfoMacOs(di: *DebugInfo, symbol: MachoSymbol, address: usize) !LineInfo {
const ofile = symbol.ofile orelse return error.MissingDebugInfo; const ofile = symbol.ofile orelse return error.MissingDebugInfo;
const gop = try di.ofiles.getOrPut(ofile); const gop = try di.ofiles.getOrPut(ofile);