mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-29 09:33:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

stage2: improve compiler error message for bad union init

Browse Source
This commit is contained in:
John Schmidt 2022-02-12 20:03:16 +01:00 committed by Veikka Tuominen
parent 3eb29f15f5
commit ee69a4b45f
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/Sema.zig
View File

@ -2631,9 +2631,24 @@ fn validateUnionInit(
union_ptr: Air.Inst.Ref,
) CompileError!void {
if (instrs.len != 1) {
// TODO add note for other field
// TODO add note for union declared here
return sema.fail(block, init_src, "only one union field can be active at once", .{});
const msg = msg: {
const msg = try sema.errMsg(
block,
init_src,
"cannot initialize multiple union fields at once, unions can only have one active field",
.{},
);
errdefer msg.destroy(sema.gpa);
for (instrs[1..]) |inst| {
const inst_data = sema.code.instructions.items(.data)[inst].pl_node;
const inst_src: LazySrcLoc = .{ .node_offset_back2tok = inst_data.src_node };
try sema.errNote(block, inst_src, msg, "additional initializer here", .{});
}
try sema.mod.errNoteNonLazy(union_obj.srcLoc(), msg, "union declared here", .{});
break :msg msg;
};
return sema.failWithOwnedErrorMsg(msg);
}
const field_ptr = instrs[0];