mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-24 15:13:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "thread: simplify and remove useless return in spawn (#8621)"

Browse Source 
This reverts commit 77cb45f59f7b37c316af1762298d6032e2b130b5.

Zig's error return traces will point to the return token if they
happen to occur, so having multiple return statements makes those
stack traces really helpful. This destroys debuggability.
This commit is contained in:
Andrew Kelley 2021-04-26 10:44:40 -07:00
parent 77cb45f59f
commit ddf9ff79bd
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/std/Thread.zig
View File

@ -360,13 +360,15 @@ pub fn spawn(comptime startFn: anytype, context: SpawnContextType(@TypeOf(startF
MainFuncs.posixThreadMain,
thread_obj.data.memory.ptr,
);
return switch (err) {
0 => thread_obj,
os.EAGAIN => error.SystemResources,
switch (err) {
0 => return thread_obj,
os.EAGAIN => return error.SystemResources,
os.EPERM => unreachable,
os.EINVAL => unreachable,
else => os.unexpectedErrno(err),
};
else => return os.unexpectedErrno(err),
}
return thread_obj;
}
var guard_end_offset: usize = undefined;