mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-01-05 04:53:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

behavior test: use expectApproxEqAbs instead of expectEqual

Browse Source 
This is to account for the small differences in math functions of
different libcs. For example, if the compiler links against glibc,
but the target is musl libc, then these values might be
slightly different.

Arguably, this is a bug in the compiler because comptime should
emulate the target, including rounding errors in libc math
functions. However that behavior is not what this particular test
is intended to cover.
This commit is contained in:
Andrew Kelley 2022-04-27 17:58:26 -07:00
parent 758ec9bdd4
commit dc62dde982
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/behavior/bugs/920.zig
View File

@ -63,6 +63,13 @@ test "bug 920 fixed" {
};
for (NormalDist1.f) |_, i| {
try std.testing.expectEqual(NormalDist1.f[i], NormalDist.f[i]);
// Here we use `expectApproxEqAbs` instead of `expectEqual` to account for the small
// differences in math functions of different libcs. For example, if the compiler
// links against glibc, but the target is musl libc, then these values might be
// slightly different.
// Arguably, this is a bug in the compiler because comptime should emulate the target,
// including rounding errors in libc math functions. However that behavior is not
// what this particular test is intended to cover.
try std.testing.expectApproxEqAbs(NormalDist1.f[i], NormalDist.f[i], @sqrt(std.math.floatEps(f64)));
}
}