From d8bdfd8192fb43ca8f6abd223396a4073e369499 Mon Sep 17 00:00:00 2001 From: Jacob Young Date: Mon, 24 Apr 2023 19:47:05 -0400 Subject: [PATCH] std: fix windows resource leaks --- lib/std/fs.zig | 1 + lib/std/os/test.zig | 2 ++ 2 files changed, 3 insertions(+) diff --git a/lib/std/fs.zig b/lib/std/fs.zig index f484b05295..8ea2cf91c1 100644 --- a/lib/std/fs.zig +++ b/lib/std/fs.zig @@ -1236,6 +1236,7 @@ pub const Dir = struct { .capable_io_mode = std.io.default_mode, .intended_io_mode = flags.intended_io_mode, }; + errdefer file.close(); var io: w.IO_STATUS_BLOCK = undefined; const range_off: w.LARGE_INTEGER = 0; const range_len: w.LARGE_INTEGER = 1; diff --git a/lib/std/os/test.zig b/lib/std/os/test.zig index 5174090712..682bd4f6f8 100644 --- a/lib/std/os/test.zig +++ b/lib/std/os/test.zig @@ -1101,6 +1101,8 @@ test "isatty" { defer tmp.cleanup(); var file = try tmp.dir.createFile("foo", .{}); + defer file.close(); + try expectEqual(os.isatty(file.handle), false); }