From d42418d6146a833f4600ca0be0b54383aac9f840 Mon Sep 17 00:00:00 2001
From: Ryan Liptak <squeek502@hotmail.com>
Date: Wed, 22 Nov 2023 16:29:56 -0800
Subject: [PATCH] Replace shell32.SHGetKnownFolderPath usage with LOCALAPPDATA
 env var

Removes the dependency on shell32.dll. This is a stop gap solution until a proper SHGetKnownFolderPath Zig implementation is written
---
 lib/std/fs/get_app_data_dir.zig | 25 +++++--------------------
 1 file changed, 5 insertions(+), 20 deletions(-)

diff --git a/lib/std/fs/get_app_data_dir.zig b/lib/std/fs/get_app_data_dir.zig
index 904cea5e7f..4fcd17efe2 100644
--- a/lib/std/fs/get_app_data_dir.zig
+++ b/lib/std/fs/get_app_data_dir.zig
@@ -15,27 +15,12 @@ pub const GetAppDataDirError = error{
 pub fn getAppDataDir(allocator: mem.Allocator, appname: []const u8) GetAppDataDirError![]u8 {
     switch (builtin.os.tag) {
         .windows => {
-            var dir_path_ptr: [*:0]u16 = undefined;
-            switch (os.windows.shell32.SHGetKnownFolderPath(
-                &os.windows.FOLDERID_LocalAppData,
-                os.windows.KF_FLAG_CREATE,
-                null,
-                &dir_path_ptr,
-            )) {
-                os.windows.S_OK => {
-                    defer os.windows.ole32.CoTaskMemFree(dir_path_ptr);
-                    const global_dir = unicode.utf16leToUtf8Alloc(allocator, mem.sliceTo(dir_path_ptr, 0)) catch |err| switch (err) {
-                        error.UnexpectedSecondSurrogateHalf => return error.AppDataDirUnavailable,
-                        error.ExpectedSecondSurrogateHalf => return error.AppDataDirUnavailable,
-                        error.DanglingSurrogateHalf => return error.AppDataDirUnavailable,
-                        error.OutOfMemory => return error.OutOfMemory,
-                    };
-                    defer allocator.free(global_dir);
-                    return fs.path.join(allocator, &[_][]const u8{ global_dir, appname });
-                },
-                os.windows.E_OUTOFMEMORY => return error.OutOfMemory,
+            const local_app_data_dir = std.process.getEnvVarOwned(allocator, "LOCALAPPDATA") catch |err| switch (err) {
+                error.OutOfMemory => |e| return e,
                 else => return error.AppDataDirUnavailable,
-            }
+            };
+            defer allocator.free(local_app_data_dir);
+            return fs.path.join(allocator, &[_][]const u8{ local_app_data_dir, appname });
         },
         .macos => {
             const home_dir = os.getenv("HOME") orelse {