mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-13 21:08:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: avoid repeating objects when linking a static library

Browse Source 
Don't pass the object files from a static library to the linker invocation.
The lib.a file already contains them.

Avoids "duplicate symbol" errors (and useless work by the linker)
This commit is contained in:
Xavier Bouchoux 2023-05-14 11:46:59 +02:00
parent 8142bc20ea
commit cea8645423
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/std/Build/Step/Compile.zig
View File

@ -2192,7 +2192,8 @@ const TransitiveDeps = struct {
if ((try td.seen_steps.fetchPut(&inner_other.step, {})) != null)
continue;
if (!dyn)
const included_in_lib = (other.kind == .lib and inner_other.kind == .obj);
if (!dyn and !included_in_lib)
try td.link_objects.append(other_link_object);
try addInner(td, inner_other, dyn or inner_other.isDynamicLibrary());