From c955379504d4866f9c474c50317b2a0da18ee631 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Mon, 22 Aug 2022 11:46:54 -0700 Subject: [PATCH] Revert "test_runner: workaround #1923, isolating error traces in tests" This reverts commit 1a32f2a7f40328799537cc94240a57054a1275bc. Sorry, this workaround is not welcome. Instead, please solve the actual issue by doing the accepted behavior in the compiler itself: > in a catch or else (handling a returned error), if the block does not > try or return error.xyz, set the index to 0 This also applies to if statements, such as the one that test runner is doing just above this hack. --- lib/test_runner.zig | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/test_runner.zig b/lib/test_runner.zig index 46b24deb45..8a3c1f0ca7 100644 --- a/lib/test_runner.zig +++ b/lib/test_runner.zig @@ -96,13 +96,6 @@ pub fn main() void { test_node.end(); }, } - // Workaround issue #1923 by clearing error stack traces between tests - // - // This is not a true fix, but helps isolate errors to the tests where they - // originate instead of confusing them all together - if (@errorReturnTrace()) |trace| { - trace.index = 0; - } } root_node.end(); if (ok_count == test_fn_list.len) {