test/link: remove redundant dependOn statements

`runAndCompare` will already depend on the `CheckObject` step itself
so it's not needed to also have the test step depend on the
check object step.
This commit is contained in:
Luuk de Gram 2022-10-18 17:20:08 +02:00
parent 10b56b21d4
commit c0fe135ff3
No known key found for this signature in database
GPG Key ID: A8CFE58E4DC7D664
7 changed files with 0 additions and 10 deletions

View File

@ -16,7 +16,6 @@ pub fn build(b: *Builder) void {
const check = exe.checkObject(.macho);
check.checkInSymtab();
check.checkNext("{*} (__TEXT,__text) external _iAmUnused");
test_step.dependOn(&check.step);
const run_cmd = check.runAndCompare();
run_cmd.expectStdOutEqual("Hello!\n");
@ -31,7 +30,6 @@ pub fn build(b: *Builder) void {
const check = exe.checkObject(.macho);
check.checkInSymtab();
check.checkNotPresent("{*} (__TEXT,__text) external _iAmUnused");
test_step.dependOn(&check.step);
const run_cmd = check.runAndCompare();
run_cmd.expectStdOutEqual("Hello!\n");

View File

@ -40,8 +40,6 @@ pub fn build(b: *Builder) void {
check_exe.checkNext("current version 10000");
check_exe.checkNext("compatibility version 10000");
test_step.dependOn(&check_exe.step);
check_exe.checkStart("cmd RPATH");
check_exe.checkNext(std.fmt.allocPrint(b.allocator, "path {s}", .{b.pathFromRoot("zig-out/lib")}) catch unreachable);

View File

@ -26,7 +26,6 @@ pub fn build(b: *Builder) void {
check_exe.checkNext("{n_value} (__TEXT,__text) external _non_main");
check_exe.checkComputeCompare("vmaddr entryoff +", .{ .op = .eq, .value = .{ .variable = "n_value" } });
test_step.dependOn(&check_exe.step);
const run = check_exe.runAndCompare();
run.expectStdOutEqual("42");

View File

@ -31,7 +31,6 @@ pub fn build(b: *Builder) void {
const check = exe.checkObject(.macho);
check.checkStart("cmd LOAD_DYLIB");
check.checkNext("name @rpath/liba.dylib");
test_step.dependOn(&check.step);
const run_cmd = check.runAndCompare();
test_step.dependOn(&run_cmd.step);

View File

@ -17,7 +17,6 @@ pub fn build(b: *Builder) void {
const check = exe.checkObject(.macho);
check.checkStart("cmd LOAD_DYLIB");
check.checkNext("name @rpath/liba.dylib");
test_step.dependOn(&check.step);
const run = check.runAndCompare();
run.cwd = b.pathFromRoot(".");

View File

@ -18,7 +18,6 @@ pub fn build(b: *Builder) void {
const check_exe = exe.checkObject(.macho);
check_exe.checkStart("cmd MAIN");
check_exe.checkNext("stacksize 100000000");
test_step.dependOn(&check_exe.step);
const run = check_exe.runAndCompare();
test_step.dependOn(&run.step);

View File

@ -33,8 +33,6 @@ pub fn build(b: *Builder) void {
check.checkNext("(undefined) weak external _a (from liba)");
check.checkNext("(undefined) weak external _asStr (from liba)");
test_step.dependOn(&check.step);
const run_cmd = check.runAndCompare();
run_cmd.expectStdOutEqual("42 42");
test_step.dependOn(&run_cmd.step);