mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-14 10:13:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

wasm: memset - correctly load the ptr for slices

Browse Source 
Previously we would use the address of the slice itself, which would
result in miscompilations and accidently setting the memory region
of the slice itself, rather than based on the `ptr` field.
This commit is contained in:
Luuk de Gram 2023-05-16 19:33:19 +02:00
parent 061d99285d
commit b93fa9833e
No known key found for this signature in database
GPG Key ID: A8CFE58E4DC7D664
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/arch/wasm/CodeGen.zig
View File

@ -4464,7 +4464,9 @@ fn airMemset(func: *CodeGen, inst: Air.Inst.Index, safety: bool) InnerError!void
.One => @as(WValue, .{ .imm32 = @intCast(u32, ptr_ty.childType().arrayLen()) }),
.C, .Many => unreachable,
};
try func.memset(ptr, len, value);
const dst_ptr = try func.sliceOrArrayPtr(ptr, ptr_ty);
try func.memset(dst_ptr, len, value);
func.finishAir(inst, .none, &.{ bin_op.lhs, bin_op.rhs });
}