mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-20 00:08:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix multiplication overflow in hash_const_val

Browse Source 
In some cases the compiler was actually emitting an 64 bit signed
multiplication, instead of a 32 bit unsigned one.
This commit is contained in:
Timon Kruiper 2020-04-02 21:32:38 +02:00 committed by Andrew Kelley
parent 5314641e11
commit b5526d0b3b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/analyze.cpp
View File

@ -5361,7 +5361,7 @@ static uint32_t hash_const_val(ZigValue *const_val) {
return result;
}
case ZigTypeIdEnumLiteral:
return buf_hash(const_val->data.x_enum_literal) * 2691276464;
return buf_hash(const_val->data.x_enum_literal) * (uint32_t)2691276464;
case ZigTypeIdEnum:
{
uint32_t result = 31643936;
@ -5429,12 +5429,12 @@ static uint32_t hash_const_val(ZigValue *const_val) {
return 2709806591;
case ZigTypeIdOptional:
if (get_src_ptr_type(const_val->type) != nullptr) {
return hash_const_val_ptr(const_val) * 1992916303;
return hash_const_val_ptr(const_val) * (uint32_t)1992916303;
} else if (const_val->type->data.maybe.child_type->id == ZigTypeIdErrorSet) {
return hash_const_val_error_set(const_val) * 3147031929;
return hash_const_val_error_set(const_val) * (uint32_t)3147031929;
} else {
if (const_val->data.x_optional) {
return hash_const_val(const_val->data.x_optional) * 1992916303;
return hash_const_val(const_val->data.x_optional) * (uint32_t)1992916303;
} else {
return 4016830364;
}