From b2f8631a3c9b2cc04a4c78f38d164130be2fb1ae Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Fri, 18 Dec 2020 21:50:44 -0700 Subject: [PATCH] ThreadPool: delete dead code If this errdefer did get run it would constitute a race condition. So I deleted the dead code for clarity. --- lib/std/{progress.zig => Progress.zig} | 0 src/ThreadPool.zig | 1 - 2 files changed, 1 deletion(-) rename lib/std/{progress.zig => Progress.zig} (100%) diff --git a/lib/std/progress.zig b/lib/std/Progress.zig similarity index 100% rename from lib/std/progress.zig rename to lib/std/Progress.zig diff --git a/src/ThreadPool.zig b/src/ThreadPool.zig index a5f59a30e7..6a59b684be 100644 --- a/src/ThreadPool.zig +++ b/src/ThreadPool.zig @@ -77,7 +77,6 @@ pub fn spawn(self: *ThreadPool, comptime func: anytype, args: anytype) !void { }; const closure = try self.allocator.create(Closure); - errdefer self.allocator.destroy(closure); closure.* = .{ .arguments = args, .pool = self,