mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-01-21 14:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

crypto/phc-encoding: forbid parameters named 'v' (#22569)

Browse Source 
The spec is ambiguous, and it's too late to change it.

So the most reasonable thing to do in order to avoid generating
strings that could be parsed differently by other implementations
is to forbid parameters named "v" at compile-time.

See https://github.com/P-H-C/phc-string-format/issues/8
This commit is contained in:
Frank Denis 2025-02-06 16:37:42 +01:00 committed by GitHub
parent 1c07eacc7f
commit b0ed602d5d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/std/crypto/phc_encoding.zig
View File

@ -75,6 +75,10 @@ pub fn BinValue(comptime max_len: usize) type {
///
/// Other fields will also be deserialized from the function parameters section.
pub fn deserialize(comptime HashResult: type, str: []const u8) Error!HashResult {
if (@hasField(HashResult, version_param_name)) {
@compileError("Field name '" ++ version_param_name ++ "'' is reserved for the algorithm version");
}
var out = mem.zeroes(HashResult);
var it = mem.splitScalar(u8, str, fields_delimiter_scalar);
var set_fields: usize = 0;
@ -198,6 +202,11 @@ pub fn calcSize(params: anytype) usize {
fn serializeTo(params: anytype, out: anytype) !void {
const HashResult = @TypeOf(params);
if (@hasField(HashResult, version_param_name)) {
@compileError("Field name '" ++ version_param_name ++ "'' is reserved for the algorithm version");
}
try out.writeAll(fields_delimiter);
try out.writeAll(params.alg_id);