mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-13 04:48:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move tokenizer error location to offending char

Browse Source 
Previously, it pointed to the start of the current token, but this made
it difficult to tell where the error occurred when it was, say, in the
middle of a string.
This commit is contained in:
Matthew McAllister 2019-01-29 16:20:38 -08:00 committed by Andrew Kelley
parent ecb0cb661a
commit ad8381e0d2
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/tokenizer.cpp
View File

@ -248,13 +248,8 @@ ATTRIBUTE_PRINTF(2, 3)
static void tokenize_error(Tokenize *t, const char *format, ...) {
t->state = TokenizeStateError;
if (t->cur_tok) {
t->out->err_line = t->cur_tok->start_line;
t->out->err_column = t->cur_tok->start_column;
} else {
t->out->err_line = t->line;
t->out->err_column = t->column;
}
t->out->err_line = t->line;
t->out->err_column = t->column;
va_list ap;
va_start(ap, format);

2
test/compile_errors.zig
View File

@ -2645,7 +2645,7 @@ pub fn addCases(cases: *tests.CompileErrorContext) void {
\\
\\export fn entry() usize { return @sizeOf(@typeOf(foo)); }
,
".tmp_source.zig:1:13: error: newline not allowed in string literal",
".tmp_source.zig:1:15: error: newline not allowed in string literal",
);
cases.add(