mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-06 06:13:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Sema+llvm: properly implement Interrupt callconv

Browse Source 
Co-authored-by: Veikka Tuominen <git@vexu.eu>
This commit is contained in:
Julian 2024-04-28 18:43:00 -04:00 committed by Andrew Kelley
parent 704f8f4013
commit ad63be7eb9
2 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/Sema.zig
View File

@ -9700,6 +9700,18 @@ fn funcCommon(
{
return sema.fail(block, param_src, "non-pointer parameter declared noalias", .{});
}
if (cc_resolved == .Interrupt) switch (target.cpu.arch) {
.x86, .x86_64 => {
const err_code_size = target.ptrBitWidth();
switch (i) {
0 => if (param_ty.zigTypeTag(mod) != .Pointer) return sema.fail(block, param_src, "parameter must be a pointer type", .{}),
1 => if (param_ty.bitSize(mod) != err_code_size) return sema.fail(block, param_src, "parameter must be a {d}-bit integer", .{err_code_size}),
else => return sema.fail(block, param_src, "Interrupt calling convention supports up to 2 parameters, found {d}", .{i + 1}),
}
},
else => return sema.fail(block, param_src, "parameters are not allowed with Interrupt calling convention", .{}),
};
}
var ret_ty_requires_comptime = false;
@ -10048,6 +10060,15 @@ fn finishFunc(
});
}
if (cc_resolved == .Interrupt and return_type.zigTypeTag(mod) != .Void) {
return sema.fail(
block,
cc_src,
"non-void return type '{}' not allowed in function with calling convention 'Interrupt'",
.{return_type.fmt(mod)},
);
}
if (cc_resolved == .Inline and is_noinline) {
return sema.fail(block, cc_src, "'noinline' function cannot have callconv 'Inline'", .{});
}

4
src/codegen/llvm.zig
View File

@ -4434,6 +4434,10 @@ pub const Object = struct {
if (!param_ty.isPtrLikeOptional(mod) and !ptr_info.flags.is_allowzero) {
try attributes.addParamAttr(llvm_arg_i, .nonnull, &o.builder);
}
if (fn_info.cc == .Interrupt) {
const child_type = try lowerType(o, Type.fromInterned(ptr_info.child));
try attributes.addParamAttr(llvm_arg_i, .{ .byval = child_type }, &o.builder);
}
if (ptr_info.flags.is_const) {
try attributes.addParamAttr(llvm_arg_i, .readonly, &o.builder);
}