mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-06 06:13:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

This commit enables fmax and fmin to differentiate between 0.0 and

Browse Source 
-0.0, making it compatible with musl.
This commit is contained in:
Koki Ueha 2025-06-18 14:15:51 +00:00 committed by Alex Rønne Petersen
parent 14ad8378a1
commit 9e340b3005
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/compiler_rt/fmax.zig
View File

@ -54,12 +54,15 @@ inline fn generic_fmax(comptime T: type, x: T, y: T) T {
return y; return y;
if (math.isNan(y)) if (math.isNan(y))
return x; return x;
if (math.signbit(x) != math.signbit(y))
return if (math.signbit(x)) y else x;
return if (x < y) y else x; return if (x < y) y else x;
} }
test "generic_fmax" { test "generic_fmax" {
inline for ([_]type{ f32, f64, c_longdouble, f80, f128 }) |T| { inline for ([_]type{ f32, f64, c_longdouble, f80, f128 }) |T| {
const nan_val = math.nan(T); const nan_val = math.nan(T);
const Int = std.meta.Int(.unsigned, @bitSizeOf(T));
try std.testing.expect(math.isNan(generic_fmax(T, nan_val, nan_val))); try std.testing.expect(math.isNan(generic_fmax(T, nan_val, nan_val)));
try std.testing.expectEqual(@as(T, 1.0), generic_fmax(T, nan_val, 1.0)); try std.testing.expectEqual(@as(T, 1.0), generic_fmax(T, nan_val, 1.0));
@ -67,5 +70,8 @@ test "generic_fmax" {
try std.testing.expectEqual(@as(T, 10.0), generic_fmax(T, 1.0, 10.0)); try std.testing.expectEqual(@as(T, 10.0), generic_fmax(T, 1.0, 10.0));
try std.testing.expectEqual(@as(T, 1.0), generic_fmax(T, 1.0, -1.0)); try std.testing.expectEqual(@as(T, 1.0), generic_fmax(T, 1.0, -1.0));
try std.testing.expectEqual(@as(Int, @bitCast(@as(T, 0.0))), @as(Int, @bitCast(generic_fmax(T, 0.0, -0.0))));
try std.testing.expectEqual(@as(Int, @bitCast(@as(T, 0.0))), @as(Int, @bitCast(generic_fmax(T, -0.0, 0.0))));
} }
} }

6
lib/compiler_rt/fmin.zig
View File

@ -54,12 +54,15 @@ inline fn generic_fmin(comptime T: type, x: T, y: T) T {
return y; return y;
if (math.isNan(y)) if (math.isNan(y))
return x; return x;
if (math.signbit(x) != math.signbit(y))
return if (math.signbit(x)) x else y;
return if (x < y) x else y; return if (x < y) x else y;
} }
test "generic_fmin" { test "generic_fmin" {
inline for ([_]type{ f32, f64, c_longdouble, f80, f128 }) |T| { inline for ([_]type{ f32, f64, c_longdouble, f80, f128 }) |T| {
const nan_val = math.nan(T); const nan_val = math.nan(T);
const Int = std.meta.Int(.unsigned, @bitSizeOf(T));
try std.testing.expect(math.isNan(generic_fmin(T, nan_val, nan_val))); try std.testing.expect(math.isNan(generic_fmin(T, nan_val, nan_val)));
try std.testing.expectEqual(@as(T, 1.0), generic_fmin(T, nan_val, 1.0)); try std.testing.expectEqual(@as(T, 1.0), generic_fmin(T, nan_val, 1.0));
@ -67,5 +70,8 @@ test "generic_fmin" {
try std.testing.expectEqual(@as(T, 1.0), generic_fmin(T, 1.0, 10.0)); try std.testing.expectEqual(@as(T, 1.0), generic_fmin(T, 1.0, 10.0));
try std.testing.expectEqual(@as(T, -1.0), generic_fmin(T, 1.0, -1.0)); try std.testing.expectEqual(@as(T, -1.0), generic_fmin(T, 1.0, -1.0));
try std.testing.expectEqual(@as(Int, @bitCast(@as(T, -0.0))), @as(Int, @bitCast(generic_fmin(T, 0.0, -0.0))));
try std.testing.expectEqual(@as(Int, @bitCast(@as(T, -0.0))), @as(Int, @bitCast(generic_fmin(T, -0.0, 0.0))));
} }
} }