mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-13 04:48:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

stage2: cmp_eq between untyped undefines values results in undef bool

Browse Source
This commit is contained in:
Mitchell Hashimoto 2022-01-31 21:24:37 -08:00 committed by Andrew Kelley
parent 3e99495ed8
commit 970f954039
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Sema.zig
View File

@ -9244,9 +9244,9 @@ fn cmpSelf(
const resolved_type = sema.typeOf(casted_lhs);
const runtime_src: LazySrcLoc = src: {
if (try sema.resolveMaybeUndefVal(block, lhs_src, casted_lhs)) |lhs_val| {
if (lhs_val.isUndef()) return sema.addConstUndef(resolved_type);
if (lhs_val.isUndef()) return sema.addConstUndef(Type.initTag(.bool));
if (try sema.resolveMaybeUndefVal(block, rhs_src, casted_rhs)) |rhs_val| {
if (rhs_val.isUndef()) return sema.addConstUndef(resolved_type);
if (rhs_val.isUndef()) return sema.addConstUndef(Type.initTag(.bool));
if (lhs_val.compare(op, rhs_val, resolved_type)) {
return Air.Inst.Ref.bool_true;
@ -9265,7 +9265,7 @@ fn cmpSelf(
// bool eq/neq more efficiently.
if (resolved_type.zigTypeTag() == .Bool) {
if (try sema.resolveMaybeUndefVal(block, rhs_src, casted_rhs)) |rhs_val| {
if (rhs_val.isUndef()) return sema.addConstUndef(resolved_type);
if (rhs_val.isUndef()) return sema.addConstUndef(Type.initTag(.bool));
return sema.runtimeBoolCmp(block, op, casted_lhs, rhs_val.toBool(), lhs_src);
}
}

2
test/behavior/math.zig
View File

@ -1024,8 +1024,6 @@ test "vector comparison" {
}
test "compare undefined literal with comptime_int" {
if (builtin.zig_backend != .stage1) return error.SkipZigTest; // TODO
var x = undefined == 1;
// x is now undefined with type bool
x = true;