diff --git a/doc/langref/test_switch_dispatch_loop.zig b/doc/langref/test_switch_dispatch_loop.zig index cc7af1704e..e3b891595e 100644 --- a/doc/langref/test_switch_dispatch_loop.zig +++ b/doc/langref/test_switch_dispatch_loop.zig @@ -15,18 +15,18 @@ fn evaluate(initial_stack: []const i32, code: []const Instruction) !i32 { // Because all code after `continue` is unreachable, this branch does // not provide a result. .add => { - try stack.append(stack.pop() + stack.pop()); + try stack.append(stack.pop().? + stack.pop().?); ip += 1; continue :vm code[ip]; }, .mul => { - try stack.append(stack.pop() * stack.pop()); + try stack.append(stack.pop().? * stack.pop().?); ip += 1; continue :vm code[ip]; }, - .end => stack.pop(), + .end => stack.pop().?, }; } diff --git a/lib/std/bounded_array.zig b/lib/std/bounded_array.zig index b88ba5a907..42c77e2e77 100644 --- a/lib/std/bounded_array.zig +++ b/lib/std/bounded_array.zig @@ -134,20 +134,14 @@ pub fn BoundedArrayAligned( return self.slice()[prev_len..][0..n]; } - /// Remove and return the last element from the slice. - /// Asserts the slice has at least one item. - pub fn pop(self: *Self) T { + /// Remove and return the last element from the slice, or return `null` if the slice is empty. + pub fn pop(self: *Self) ?T { + if (self.len == 0) return null; const item = self.get(self.len - 1); self.len -= 1; return item; } - /// Remove and return the last element from the slice, or - /// return `null` if the slice is empty. - pub fn popOrNull(self: *Self) ?T { - return if (self.len == 0) null else self.pop(); - } - /// Return a slice of only the extra capacity after items. /// This can be useful for writing directly into it. /// Note that such an operation must be followed up with a @@ -229,7 +223,7 @@ pub fn BoundedArrayAligned( /// This operation is O(N). pub fn orderedRemove(self: *Self, i: usize) T { const newlen = self.len - 1; - if (newlen == i) return self.pop(); + if (newlen == i) return self.pop().?; const old_item = self.get(i); for (self.slice()[i..newlen], 0..) |*b, j| b.* = self.get(i + 1 + j); self.set(newlen, undefined); @@ -241,9 +235,9 @@ pub fn BoundedArrayAligned( /// The empty slot is filled from the end of the slice. /// This operation is O(1). pub fn swapRemove(self: *Self, i: usize) T { - if (self.len - 1 == i) return self.pop(); + if (self.len - 1 == i) return self.pop().?; const old_item = self.get(i); - self.set(i, self.pop()); + self.set(i, self.pop().?); return old_item; } @@ -339,8 +333,8 @@ test BoundedArray { try testing.expectEqual(a.pop(), 0xff); try a.resize(1); - try testing.expectEqual(a.popOrNull(), 0); - try testing.expectEqual(a.popOrNull(), null); + try testing.expectEqual(a.pop(), 0); + try testing.expectEqual(a.pop(), null); var unused = a.unusedCapacitySlice(); @memset(unused[0..8], 2); unused[8] = 3; @@ -397,7 +391,7 @@ test BoundedArray { try testing.expectEqual(added_slice.len, 3); try testing.expectEqual(a.len, 36); - while (a.popOrNull()) |_| {} + while (a.pop()) |_| {} const w = a.writer(); const s = "hello, this is a test string"; try w.writeAll(s);