diff --git a/lib/std/math/nextafter.zig b/lib/std/math/nextafter.zig index 9008858a62..7d2396ed26 100644 --- a/lib/std/math/nextafter.zig +++ b/lib/std/math/nextafter.zig @@ -102,8 +102,6 @@ fn nextAfterFloat(comptime T: type, x: T, y: T) T { } test "math.nextAfter.int" { - if (@import("builtin").zig_backend == .stage2_x86_64) return error.SkipZigTest; - try expect(nextAfter(i0, 0, 0) == 0); try expect(nextAfter(u0, 0, 0) == 0); try expect(nextAfter(i1, 0, 0) == 0); diff --git a/src/arch/x86_64/CodeGen.zig b/src/arch/x86_64/CodeGen.zig index a0a83ee7ab..776eb1c44c 100644 --- a/src/arch/x86_64/CodeGen.zig +++ b/src/arch/x86_64/CodeGen.zig @@ -3776,6 +3776,9 @@ fn airAddSubWithOverflow(self: *Self, inst: Air.Inst.Index) !void { .Vector => return self.fail("TODO implement add/sub with overflow for Vector type", .{}), .Int => { try self.spillEflagsIfOccupied(); + try self.spillRegisters(&.{ .rcx, .rdi, .rsi }); + const reg_locks = self.register_manager.lockRegsAssumeUnused(3, .{ .rcx, .rdi, .rsi }); + defer for (reg_locks) |lock| self.register_manager.unlockReg(lock); const partial_mcv = try self.genBinOp(null, switch (tag) { .add_with_overflow => .add, @@ -3839,8 +3842,10 @@ fn airShlWithOverflow(self: *Self, inst: Air.Inst.Index) !void { .Vector => return self.fail("TODO implement shl with overflow for Vector type", .{}), .Int => { try self.spillEflagsIfOccupied(); + try self.spillRegisters(&.{ .rcx, .rdi, .rsi }); + const reg_locks = self.register_manager.lockRegsAssumeUnused(3, .{ .rcx, .rdi, .rsi }); + defer for (reg_locks) |lock| self.register_manager.unlockReg(lock); - try self.register_manager.getReg(.rcx, null); const lhs = try self.resolveInst(bin_op.lhs); const rhs = try self.resolveInst(bin_op.rhs); @@ -4296,8 +4301,8 @@ fn airMulWithOverflow(self: *Self, inst: Air.Inst.Index) !void { }; try self.spillEflagsIfOccupied(); - try self.spillRegisters(&.{ .rax, .rcx, .rdx }); - const reg_locks = self.register_manager.lockRegsAssumeUnused(3, .{ .rax, .rcx, .rdx }); + try self.spillRegisters(&.{ .rax, .rcx, .rdx, .rdi, .rsi }); + const reg_locks = self.register_manager.lockRegsAssumeUnused(5, .{ .rax, .rcx, .rdx, .rdi, .rsi }); defer for (reg_locks) |lock| self.register_manager.unlockReg(lock); const cc: Condition = switch (dst_info.signedness) { @@ -8273,8 +8278,8 @@ fn genShiftBinOp( assert(rhs_ty.abiSize(mod) == 1); try self.register_manager.getReg(.rcx, null); - const rcx_lock = self.register_manager.lockRegAssumeUnused(.rcx); - defer self.register_manager.unlockReg(rcx_lock); + const rcx_lock = self.register_manager.lockReg(.rcx); + defer if (rcx_lock) |lock| self.register_manager.unlockReg(lock); const lhs_lock = switch (lhs_mcv) { .register => |reg| self.register_manager.lockReg(reg),