From 861df93768ed007ce6f5e6928fc3af8c5860f551 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Wed, 16 Oct 2024 12:25:13 -0700 Subject: [PATCH] link.Elf: fix double free of header in parseDso --- src/link/Elf.zig | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/link/Elf.zig b/src/link/Elf.zig index 56571be5b3..59694c6ae9 100644 --- a/src/link/Elf.zig +++ b/src/link/Elf.zig @@ -1506,10 +1506,7 @@ fn parseDso( const soname = header.soname() orelse dso.path.basename(); const gop = try shared_objects.getOrPut(gpa, soname); - if (gop.found_existing) { - header.deinit(gpa); - return; - } + if (gop.found_existing) return; errdefer _ = shared_objects.pop(); const index: File.Index = @intCast(try files.addOne(gpa));