From 838d52a8beaf1eaa9ca7efe1d586d1ad4925560e Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Fri, 8 Sep 2017 00:45:45 -0400 Subject: [PATCH] std.os.ChildProcess: don't expect all SIGCHLD to come from spawn --- std/os/child_process.zig | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/std/os/child_process.zig b/std/os/child_process.zig index c02ffe8a7a..1ab1a9fa35 100644 --- a/std/os/child_process.zig +++ b/std/os/child_process.zig @@ -341,8 +341,11 @@ extern fn sigchld_handler(_: i32) { var status: i32 = undefined; const pid_result = posix.waitpid(-1, &status, posix.WNOHANG); const err = posix.getErrno(pid_result); - if (err == posix.ECHILD) { - return; + if (err > 0) { + if (err == posix.ECHILD) { + return; + } + unreachable; } handleTerm(i32(pid_result), status); } @@ -352,12 +355,10 @@ fn handleTerm(pid: i32, status: i32) { var it = children_nodes.first; while (it) |node| : (it = node.next) { if (node.data.pid == pid) { - assert(node.data.term == null); node.data.handleWaitResult(status); return; } } - unreachable; } const sigchld_set = {