mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-12 20:37:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

InternPool: avoid indexToKey recursion for type_slice

Browse Source 
This is a hot function, and recursion makes it more difficult to
profile, as well as likely making it more difficult to optimize.
This commit is contained in:
Andrew Kelley 2023-05-29 13:47:13 -07:00
parent 5580a69d71
commit 804740af4c
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/InternPool.zig
View File

@ -2455,10 +2455,21 @@ pub fn indexToKey(ip: *const InternPool, index: Index) Key {
},
.type_slice => {
const ptr_type_index = @intToEnum(Index, data);
var result = ip.indexToKey(ptr_type_index).ptr_type;
result.size = .Slice;
return .{ .ptr_type = result };
assert(ip.items.items(.tag)[data] == .type_pointer);
const ptr_info = ip.extraData(Pointer, ip.items.items(.data)[data]);
return .{ .ptr_type = .{
.elem_type = ptr_info.child,
.sentinel = ptr_info.sentinel,
.alignment = ptr_info.flags.alignment,
.size = .Slice,
.is_const = ptr_info.flags.is_const,
.is_volatile = ptr_info.flags.is_volatile,
.is_allowzero = ptr_info.flags.is_allowzero,
.address_space = ptr_info.flags.address_space,
.vector_index = ptr_info.flags.vector_index,
.host_size = ptr_info.packed_offset.host_size,
.bit_offset = ptr_info.packed_offset.bit_offset,
} };
},
.type_optional => .{ .opt_type = @intToEnum(Index, data) },