From 800495afab7260d0a32786dd1f26eb5807b1f007 Mon Sep 17 00:00:00 2001
From: Jacob Young <jacobly0@users.noreply.github.com>
Date: Fri, 23 Feb 2024 07:51:23 +0100
Subject: [PATCH] Builder: fix minor llvm ir syntax errors

---
 src/codegen/llvm/Builder.zig | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/src/codegen/llvm/Builder.zig b/src/codegen/llvm/Builder.zig
index 7bbfb4426a..3745ba1ced 100644
--- a/src/codegen/llvm/Builder.zig
+++ b/src/codegen/llvm/Builder.zig
@@ -1790,6 +1790,18 @@ pub const Linkage = enum(u4) {
     ) @TypeOf(writer).Error!void {
         if (self != .external) try writer.print(" {s}", .{@tagName(self)});
     }
+
+    fn formatOptional(
+        data: ?Linkage,
+        comptime _: []const u8,
+        _: std.fmt.FormatOptions,
+        writer: anytype,
+    ) @TypeOf(writer).Error!void {
+        if (data) |linkage| try writer.print(" {s}", .{@tagName(linkage)});
+    }
+    pub fn fmtOptional(self: ?Linkage) std.fmt.Formatter(formatOptional) {
+        return .{ .data = self };
+    }
 };
 
 pub const Preemption = enum {
@@ -8073,10 +8085,9 @@ pub const Metadata = enum(u32) {
                     try format(.{
                         .formatter = data.formatter,
                         .node = @unionInit(FormatData.Node, @tagName(tag)["local_".len..], node),
-                    }, "", fmt_opts, writer);
+                    }, "%", fmt_opts, writer);
                 },
-                .string => |node| try writer.print("{s}{}", .{
-                    if (is_specialized) "" else "!",
+                .string => |node| try writer.print((if (is_specialized) "" else "!") ++ "{}", .{
                     node.fmt(builder),
                 }),
                 inline .bool, .u32, .u64 => |node| try writer.print("{}", .{node}),
@@ -9276,7 +9287,8 @@ pub fn printUnbuffered(
                 \\
             , .{
                 variable.global.fmt(self),
-                global.linkage,
+                Linkage.fmtOptional(if (global.linkage == .external and
+                    variable.init != .no_init) null else global.linkage),
                 global.preemption,
                 global.visibility,
                 global.dll_storage_class,