mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-15 05:48:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

LLVM: fix UAF when lowering debug info for structs

Browse Source 
Gotta call the get() function inside the loop if the loop adds anything
to InternPool.
This commit is contained in:
Andrew Kelley 2023-09-21 21:55:41 -07:00
parent 81b5df347a
commit 747440677d
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/codegen/llvm.zig
View File

@ -2495,17 +2495,16 @@ pub const Object = struct {
}
const struct_type = mod.typeToStruct(ty).?;
const field_types = struct_type.field_types.get(ip);
var di_fields: std.ArrayListUnmanaged(*llvm.DIType) = .{};
defer di_fields.deinit(gpa);
try di_fields.ensureUnusedCapacity(gpa, field_types.len);
try di_fields.ensureUnusedCapacity(gpa, struct_type.field_types.len);
comptime assert(struct_layout_version == 2);
var it = struct_type.iterateRuntimeOrder(ip);
while (it.next()) |field_index| {
const field_ty = field_types[field_index].toType();
const field_ty = struct_type.field_types.get(ip)[field_index].toType();
if (!field_ty.hasRuntimeBitsIgnoreComptime(mod)) continue;
const field_size = field_ty.abiSize(mod);
const field_align = mod.structFieldAlignment(