From 6a15e8a7a771bcbf2534cceecd77231344aafbf8 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Wed, 30 Oct 2019 21:29:45 -0400 Subject: [PATCH] add comments to disabled tests linking to the tracking issue --- lib/std/atomic/queue.zig | 2 ++ lib/std/atomic/stack.zig | 2 ++ lib/std/event/channel.zig | 3 +++ lib/std/event/group.zig | 2 ++ lib/std/event/lock.zig | 3 +++ lib/std/mutex.zig | 2 ++ lib/std/os/test.zig | 8 ++++++++ lib/std/statically_initialized_mutex.zig | 2 ++ test/stage1/behavior/byteswap.zig | 6 ++++-- test/stage1/behavior/vector.zig | 2 ++ 10 files changed, 30 insertions(+), 2 deletions(-) diff --git a/lib/std/atomic/queue.zig b/lib/std/atomic/queue.zig index a9d7649829..6aac3246c7 100644 --- a/lib/std/atomic/queue.zig +++ b/lib/std/atomic/queue.zig @@ -152,7 +152,9 @@ const puts_per_thread = 500; const put_thread_count = 3; test "std.atomic.Queue" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + var plenty_of_memory = try std.heap.direct_allocator.alloc(u8, 300 * 1024); defer std.heap.direct_allocator.free(plenty_of_memory); diff --git a/lib/std/atomic/stack.zig b/lib/std/atomic/stack.zig index ee6238542f..f96696c923 100644 --- a/lib/std/atomic/stack.zig +++ b/lib/std/atomic/stack.zig @@ -86,7 +86,9 @@ const puts_per_thread = 500; const put_thread_count = 3; test "std.atomic.stack" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + var plenty_of_memory = try std.heap.direct_allocator.alloc(u8, 300 * 1024); defer std.heap.direct_allocator.free(plenty_of_memory); diff --git a/lib/std/event/channel.zig b/lib/std/event/channel.zig index b46cca1261..f8539d5259 100644 --- a/lib/std/event/channel.zig +++ b/lib/std/event/channel.zig @@ -304,9 +304,12 @@ pub fn Channel(comptime T: type) type { } test "std.event.Channel" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + // https://github.com/ziglang/zig/issues/1908 if (builtin.single_threaded) return error.SkipZigTest; + // https://github.com/ziglang/zig/issues/3251 if (builtin.os == .freebsd) return error.SkipZigTest; diff --git a/lib/std/event/group.zig b/lib/std/event/group.zig index 6991fb2fa6..95715edcee 100644 --- a/lib/std/event/group.zig +++ b/lib/std/event/group.zig @@ -81,7 +81,9 @@ pub fn Group(comptime ReturnType: type) type { } test "std.event.Group" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + // https://github.com/ziglang/zig/issues/1908 if (builtin.single_threaded) return error.SkipZigTest; diff --git a/lib/std/event/lock.zig b/lib/std/event/lock.zig index f86afdbf65..57d295d6b6 100644 --- a/lib/std/event/lock.zig +++ b/lib/std/event/lock.zig @@ -116,9 +116,12 @@ pub const Lock = struct { }; test "std.event.Lock" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + // TODO https://github.com/ziglang/zig/issues/1908 if (builtin.single_threaded) return error.SkipZigTest; + // TODO https://github.com/ziglang/zig/issues/3251 if (builtin.os == .freebsd) return error.SkipZigTest; diff --git a/lib/std/mutex.zig b/lib/std/mutex.zig index 3eea8d0c71..e7dd173b01 100644 --- a/lib/std/mutex.zig +++ b/lib/std/mutex.zig @@ -130,7 +130,9 @@ const TestContext = struct { }; test "std.Mutex" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + var plenty_of_memory = try std.heap.direct_allocator.alloc(u8, 300 * 1024); defer std.heap.direct_allocator.free(plenty_of_memory); diff --git a/lib/std/os/test.zig b/lib/std/os/test.zig index 534ebfac9d..7ea834e28c 100644 --- a/lib/std/os/test.zig +++ b/lib/std/os/test.zig @@ -16,7 +16,9 @@ const AtomicRmwOp = builtin.AtomicRmwOp; const AtomicOrder = builtin.AtomicOrder; test "makePath, put some files in it, deleteTree" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + try fs.makePath(a, "os_test_tmp" ++ fs.path.sep_str ++ "b" ++ fs.path.sep_str ++ "c"); try io.writeFile("os_test_tmp" ++ fs.path.sep_str ++ "b" ++ fs.path.sep_str ++ "c" ++ fs.path.sep_str ++ "file.txt", "nonsense"); try io.writeFile("os_test_tmp" ++ fs.path.sep_str ++ "b" ++ fs.path.sep_str ++ "file2.txt", "blah"); @@ -29,7 +31,9 @@ test "makePath, put some files in it, deleteTree" { } test "access file" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + try fs.makePath(a, "os_test_tmp"); if (File.access("os_test_tmp" ++ fs.path.sep_str ++ "file.txt")) |ok| { @panic("expected error"); @@ -97,7 +101,9 @@ test "cpu count" { } test "AtomicFile" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + var buffer: [1024]u8 = undefined; const allocator = &std.heap.FixedBufferAllocator.init(buffer[0..]).allocator; const test_out_file = "tmp_atomic_file_test_dest.txt"; @@ -118,7 +124,9 @@ test "AtomicFile" { } test "thread local storage" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + if (builtin.single_threaded) return error.SkipZigTest; const thread1 = try Thread.spawn({}, testTls); const thread2 = try Thread.spawn({}, testTls); diff --git a/lib/std/statically_initialized_mutex.zig b/lib/std/statically_initialized_mutex.zig index 31ef643384..27d2722378 100644 --- a/lib/std/statically_initialized_mutex.zig +++ b/lib/std/statically_initialized_mutex.zig @@ -61,7 +61,9 @@ pub const StaticallyInitializedMutex = switch (builtin.os) { }; test "std.StaticallyInitializedMutex" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + const TestContext = struct { data: i128, diff --git a/test/stage1/behavior/byteswap.zig b/test/stage1/behavior/byteswap.zig index 4ba421679d..5408b893f5 100644 --- a/test/stage1/behavior/byteswap.zig +++ b/test/stage1/behavior/byteswap.zig @@ -40,9 +40,11 @@ test "@byteSwap integers" { } test "@byteSwap vectors" { - // Disabled because of #3317 + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; - if (@import("builtin").arch == .mipsel) return error.SkipZigTest; + + // https://github.com/ziglang/zig/issues/3317 + if (builtin.arch == .mipsel) return error.SkipZigTest; const ByteSwapVectorTest = struct { fn run() void { diff --git a/test/stage1/behavior/vector.zig b/test/stage1/behavior/vector.zig index dd8e5f1f7e..26f3b34038 100644 --- a/test/stage1/behavior/vector.zig +++ b/test/stage1/behavior/vector.zig @@ -112,7 +112,9 @@ test "array to vector" { } test "vector casts of sizes not divisable by 8" { + // https://github.com/ziglang/zig/issues/3563 if (builtin.os == .dragonfly) return error.SkipZigTest; + const S = struct { fn doTheTest() void { {