mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-06 06:13:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix logic bug in groupAsync

Browse Source
This commit is contained in:
Loris Cro 2025-11-07 13:33:45 +01:00 committed by Andrew Kelley
parent ff883dd6ce
commit 69f9395b38
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/std/Io/Threaded.zig
View File

@ -695,10 +695,6 @@ fn groupAsync(
t.mutex.lock(); t.mutex.lock();
// Append to the group linked list inside the mutex to make `Io.Group.async` thread-safe.
gc.node = .{ .next = @ptrCast(@alignCast(group.token)) };
group.token = &gc.node;
if (t.available_thread_count == 0) { if (t.available_thread_count == 0) {
if (t.cpu_count != 0 and t.threads.items.len >= t.cpu_count) { if (t.cpu_count != 0 and t.threads.items.len >= t.cpu_count) {
t.mutex.unlock(); t.mutex.unlock();
@ -727,6 +723,10 @@ fn groupAsync(
t.available_thread_count -= 1; t.available_thread_count -= 1;
} }
// Append to the group linked list inside the mutex to make `Io.Group.async` thread-safe.
gc.node = .{ .next = @ptrCast(@alignCast(group.token)) };
group.token = &gc.node;
t.run_queue.prepend(&gc.closure.node); t.run_queue.prepend(&gc.closure.node);
// This needs to be done before unlocking the mutex to avoid a race with // This needs to be done before unlocking the mutex to avoid a race with