From 5ee2816f6226eff8990749d44b1b9003b10c6170 Mon Sep 17 00:00:00 2001 From: David Rubin Date: Wed, 25 Dec 2024 01:37:32 -0800 Subject: [PATCH] llvm: fix UB in metadata printer --- src/codegen/llvm/Builder.zig | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/codegen/llvm/Builder.zig b/src/codegen/llvm/Builder.zig index 3c687b5e3c..f5b05dfecd 100644 --- a/src/codegen/llvm/Builder.zig +++ b/src/codegen/llvm/Builder.zig @@ -9829,6 +9829,8 @@ pub fn printUnbuffered( extra.then.toInst(&function).fmt(function_index, self), extra.@"else".toInst(&function).fmt(function_index, self), }); + metadata_formatter.need_comma = true; + defer metadata_formatter.need_comma = undefined; switch (extra.weights) { .none => {}, .unpredictable => try writer.writeAll("!unpredictable !{}"), @@ -10110,6 +10112,8 @@ pub fn printUnbuffered( }, ); try writer.writeAll(" ]"); + metadata_formatter.need_comma = true; + defer metadata_formatter.need_comma = undefined; switch (extra.data.weights) { .none => {}, .unpredictable => try writer.writeAll("!unpredictable !{}"),