From 5ac2cf9c28253a7b6144c9f5b19f68df1e26527c Mon Sep 17 00:00:00 2001
From: Josh Wolfe <thejoshwolfe@gmail.com>
Date: Wed, 20 Sep 2017 22:41:07 -0700
Subject: [PATCH] fix assignment needing an lvalue

---
 src/parsec.cpp  | 17 ++++++++++++++++-
 test/parsec.zig |  5 ++++-
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/src/parsec.cpp b/src/parsec.cpp
index bfe7181955..f1ca4c9f5f 100644
--- a/src/parsec.cpp
+++ b/src/parsec.cpp
@@ -942,6 +942,21 @@ static AstNode *trans_create_bin_op(Context *c, AstNode *block, Expr *lhs, BinOp
     return node;
 }
 
+static AstNode *trans_create_assign(Context *c, AstNode *block, Expr *lhs, Expr *rhs) {
+    AstNode *node = trans_create_node(c, NodeTypeBinOpExpr);
+    node->data.bin_op_expr.bin_op = BinOpTypeAssign;
+
+    node->data.bin_op_expr.op1 = trans_expr(c, true, block, lhs, TransLValue);
+    if (node->data.bin_op_expr.op1 == nullptr)
+        return nullptr;
+
+    node->data.bin_op_expr.op2 = trans_expr(c, true, block, rhs, TransRValue);
+    if (node->data.bin_op_expr.op2 == nullptr)
+        return nullptr;
+
+    return node;
+}
+
 static AstNode *trans_binary_operator(Context *c, bool result_used, AstNode *block, BinaryOperator *stmt) {
     switch (stmt->getOpcode()) {
         case BO_PtrMemD:
@@ -1026,7 +1041,7 @@ static AstNode *trans_binary_operator(Context *c, bool result_used, AstNode *blo
                 emit_warning(c, stmt->getLocStart(), "TODO handle more C binary operators: BO_Assign with result_used");
                 return nullptr;
             }
-            return trans_create_bin_op(c, block, stmt->getLHS(), BinOpTypeAssign, stmt->getRHS());
+            return trans_create_assign(c, block, stmt->getLHS(), stmt->getRHS());
         case BO_MulAssign:
             emit_warning(c, stmt->getLocStart(), "TODO handle more C binary operators: BO_MulAssign");
             return nullptr;
diff --git a/test/parsec.zig b/test/parsec.zig
index 482736713d..78b4c8b782 100644
--- a/test/parsec.zig
+++ b/test/parsec.zig
@@ -455,11 +455,14 @@ pub fn addCases(cases: &tests.ParseCContext) {
         \\int max(int a) {
         \\    int tmp;
         \\    tmp = a;
+        \\    a = tmp;
         \\}
     ,
-        \\export fn max(a: c_int) -> c_int {
+        \\export fn max(_arg_a: c_int) -> c_int {
+        \\    var a = _arg_a;
         \\    var tmp: c_int;
         \\    tmp = a;
+        \\    a = tmp;
         \\}
     );