mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-01-16 04:15:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

macho: improve reporting of missing symbols

Browse Source 
Fix a typo in TLV bootstrap symbol: __tlv_bootstrap.
This commit is contained in:
Jakub Konka 2023-04-05 18:31:47 +02:00
parent ef645ab175
commit 57f9304275
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/link/MachO.zig
View File

@ -702,9 +702,9 @@ pub fn flushModule(self: *MachO, comp: *Compilation, prog_node: *std.Progress.No
if (self.dyld_stub_binder_index == null) {
self.dyld_stub_binder_index = try self.addUndefined("dyld_stub_binder", .add_got);
}
// if (!self.base.options.single_threaded) {
// _ = try self.addUndefined("_tlv_bootstrap", .none);
// }
if (!self.base.options.single_threaded) {
_ = try self.addUndefined("__tlv_bootstrap", .none);
}
try self.createMhExecuteHeaderSymbol();
@ -713,6 +713,12 @@ pub fn flushModule(self: *MachO, comp: *Compilation, prog_node: *std.Progress.No
try self.resolveSymbolsInDylibs(&actions);
if (self.unresolved.count() > 0) {
for (self.unresolved.keys()) |index| {
// TODO: convert into compiler errors.
const global = self.globals.items[index];
const sym_name = self.getSymbolName(global);
log.err("undefined symbol reference '{s}'", .{sym_name});
}
return error.UndefinedSymbolReference;
}