remove duplicate isNan implementation

This commit is contained in:
Shawn Landden 2019-11-04 18:13:47 -08:00 committed by Andrew Kelley
parent 3d907b2943
commit 55685ae780

View File

@ -7,6 +7,7 @@
const std = @import("std");
const builtin = @import("builtin");
const maxInt = std.math.maxInt;
const isNan = std.math.isNan;
const is_wasm = switch (builtin.arch) {
.wasm32, .wasm64 => true,
@ -480,7 +481,7 @@ fn generic_fmod(comptime T: type, x: T, y: T) T {
const sx = if (T == f32) @intCast(u32, ux & 0x80000000) else @intCast(i32, ux >> bits_minus_1);
var i: uint = undefined;
if (uy << 1 == 0 or isNan(uint, uy) or ex == mask)
if (uy << 1 == 0 or isNan(@bitCast(T, uy)) or ex == mask)
return (x * y) / (x * y);
if (ux << 1 <= uy << 1) {
@ -549,18 +550,6 @@ fn generic_fmod(comptime T: type, x: T, y: T) T {
return @bitCast(T, ux);
}
fn isNan(comptime T: type, bits: T) bool {
if (T == u16) {
return (bits & 0x7fff) > 0x7c00;
} else if (T == u32) {
return (bits & 0x7fffffff) > 0x7f800000;
} else if (T == u64) {
return (bits & (maxInt(u64) >> 1)) > (u64(0x7ff) << 52);
} else {
unreachable;
}
}
// NOTE: The original code is full of implicit signed -> unsigned assumptions and u32 wraparound
// behaviour. Most intermediate i32 values are changed to u32 where appropriate but there are
// potentially some edge cases remaining that are not handled in the same way.