mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-16 06:18:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

std: work around current packed struct situation

Browse Source 
As of 6249a24, align() is not allowed on packed struct fields
and as such the align(4) was removed from the first field of
EdidOverrideProtocolAttributes. The endgame here is packed struct
backed by explicit integers, in this case a u32, but until that
is implemented put the align(4) on the pointer to avoid breaking
someone's UEFI code in a hard to debug way.
This commit is contained in:
Isaac Freund 2022-02-24 10:27:24 +01:00 committed by Andrew Kelley
parent e06cb31659
commit 52a2aa11e2
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/std/os/uefi/protocols/edid_override_protocol.zig
View File

@ -8,7 +8,15 @@ pub const EdidOverrideProtocol = extern struct {
_get_edid: fn (*const EdidOverrideProtocol, Handle, *u32, *usize, *?[*]u8) callconv(.C) Status,
/// Returns policy information and potentially a replacement EDID for the specified video output device.
pub fn getEdid(self: *const EdidOverrideProtocol, handle: Handle, attributes: *EdidOverrideProtocolAttributes, edid_size: *usize, edid: *?[*]u8) Status {
pub fn getEdid(
self: *const EdidOverrideProtocol,
handle: Handle,
/// The align(4) here should really be part of the EdidOverrideProtocolAttributes type.
/// TODO remove this workaround when packed(u32) structs are implemented.
attributes: *align(4) EdidOverrideProtocolAttributes,
edid_size: *usize,
edid: *?[*]u8,
) Status {
return self._get_edid(self, handle, @ptrCast(*u32, attributes), edid_size, edid);
}