From 525466b49d4acc0d33f528bc9d53392c309a43bd Mon Sep 17 00:00:00 2001 From: Chris Clark <78776922+coffeebe4code@users.noreply.github.com> Date: Mon, 24 Mar 2025 14:14:01 -0500 Subject: [PATCH] std.zig.Ast: Fix error case memory leak in parse() --- lib/std/zig/Ast.zig | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/std/zig/Ast.zig b/lib/std/zig/Ast.zig index 48cb7572f6..7950df7152 100644 --- a/lib/std/zig/Ast.zig +++ b/lib/std/zig/Ast.zig @@ -181,14 +181,19 @@ pub fn parse(gpa: Allocator, source: [:0]const u8, mode: Mode) Allocator.Error!A .zon => try parser.parseZon(), } + const extra_data = try parser.extra_data.toOwnedSlice(gpa); + errdefer gpa.free(extra_data); + const errors = try parser.errors.toOwnedSlice(gpa); + errdefer gpa.free(errors); + // TODO experiment with compacting the MultiArrayList slices here return Ast{ .source = source, .mode = mode, .tokens = tokens.toOwnedSlice(), .nodes = parser.nodes.toOwnedSlice(), - .extra_data = try parser.extra_data.toOwnedSlice(gpa), - .errors = try parser.errors.toOwnedSlice(gpa), + .extra_data = extra_data, + .errors = errors, }; }