mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-06 06:13:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix windows bug in Progress.zig

Browse Source 
This bug caused the compiler to deadlock when multiple c objects
were build in parallel.

Thanks @kprotty for finding this bug!
This commit is contained in:
Timon Kruiper 2021-01-23 16:42:34 +01:00 committed by Andrew Kelley
parent 15278b7f4b
commit 4f7d76f19c
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/std/Progress.zig
View File

@ -103,7 +103,11 @@ pub const Node = struct {
} }
parent.completeOne(); parent.completeOne();
} else { } else {
self.context.done = true; {
const held = self.context.update_lock.acquire();
defer held.release();
self.context.done = true;
}
self.context.refresh(); self.context.refresh();
} }
} }

2
lib/std/os/windows/kernel32.zig
View File

@ -299,6 +299,6 @@ pub extern "kernel32" fn SleepConditionVariableSRW(
f: ULONG, f: ULONG,
) callconv(WINAPI) BOOL; ) callconv(WINAPI) BOOL;
pub extern "kernel32" fn TryAcquireSRWLockExclusive(s: *SRWLOCK) callconv(WINAPI) BOOL; pub extern "kernel32" fn TryAcquireSRWLockExclusive(s: *SRWLOCK) callconv(WINAPI) BOOLEAN;
pub extern "kernel32" fn AcquireSRWLockExclusive(s: *SRWLOCK) callconv(WINAPI) void; pub extern "kernel32" fn AcquireSRWLockExclusive(s: *SRWLOCK) callconv(WINAPI) void;
pub extern "kernel32" fn ReleaseSRWLockExclusive(s: *SRWLOCK) callconv(WINAPI) void; pub extern "kernel32" fn ReleaseSRWLockExclusive(s: *SRWLOCK) callconv(WINAPI) void;