From 4f0f3a7d45ef73d0e3e1721e21d17b3506815402 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Tue, 26 Sep 2017 03:17:35 -0400 Subject: [PATCH] std.os.ChildProcess: setgid before setuid otherwise we thwart our permissions to setuid --- std/os/child_process.zig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/std/os/child_process.zig b/std/os/child_process.zig index 7a4b508cfc..f88b9d4078 100644 --- a/std/os/child_process.zig +++ b/std/os/child_process.zig @@ -299,14 +299,14 @@ pub const ChildProcess = struct { |err| forkChildErrReport(err_pipe[1], err); } - if (self.uid) |uid| { - os.posix_setreuid(uid, uid) %% |err| forkChildErrReport(err_pipe[1], err); - } - if (self.gid) |gid| { os.posix_setregid(gid, gid) %% |err| forkChildErrReport(err_pipe[1], err); } + if (self.uid) |uid| { + os.posix_setreuid(uid, uid) %% |err| forkChildErrReport(err_pipe[1], err); + } + os.posixExecve(self.argv, env_map, self.allocator) %% |err| forkChildErrReport(err_pipe[1], err); }