mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-01-05 21:13:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

CBE: Only generate (void) for calls whose return values are ignored

Browse Source
This commit is contained in:
Noam Preil 2020-07-13 01:12:49 -04:00
parent a124b027b4
commit 4a46248198
No known key found for this signature in database
GPG Key ID: FC347E7C85BE8238
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src-self-hosted/cgen.zig
View File

@ -120,13 +120,13 @@ pub fn generate(file: *C, decl: *Decl) !void {
try writer.writeAll(");");
},
.call => {
const call = inst.cast(ir.Inst.Call).?.args;
if (call.func.cast(ir.Inst.Constant)) |func_inst| {
const call = inst.cast(ir.Inst.Call).?;
if (call.args.func.cast(ir.Inst.Constant)) |func_inst| {
if (func_inst.val.cast(Value.Payload.Function)) |func_val| {
const target = func_val.func.owner_decl;
const target_ty = target.typed_value.most_recent.typed_value.ty;
const ret_ty = target_ty.fnReturnType().tag();
if (target_ty.fnReturnType().hasCodeGenBits()) {
if (target_ty.fnReturnType().hasCodeGenBits() and call.base.isUnused()) {
try writer.print("(void)", .{});
}
const tname = mem.spanZ(target.name);
@ -139,7 +139,7 @@ pub fn generate(file: *C, decl: *Decl) !void {
} else {
return file.fail(decl.src(), "TODO non-function call target?", .{});
}
if (call.args.len != 0) {
if (call.args.args.len != 0) {
return file.fail(decl.src(), "TODO function arguments", .{});
}
} else {