mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-01-20 22:35:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

std.Build.CompileStep: delete install_step field

Browse Source 
This was used to ensure that an artifact would only be installed once,
but this is not only unnecessary, but actively harmful, in the face of
dependencies.

see #15079
This commit is contained in:
Andrew Kelley 2023-04-10 16:38:24 -07:00
parent d2ad3f5074
commit 38698f4f6a
2 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/std/Build/CompileStep.zig
View File

@ -111,7 +111,6 @@ vcpkg_bin_path: ?[]const u8 = null,
/// This may be set in order to override the default install directory
override_dest_dir: ?InstallDir,
installed_path: ?[]const u8,
install_step: ?*InstallArtifactStep,
/// Base address for an executable image.
image_base: ?u64 = null,
@ -390,7 +389,6 @@ pub fn create(owner: *std.Build, options: Options) *CompileStep {
.output_dir = null,
.override_dest_dir = null,
.installed_path = null,
.install_step = null,
.force_undefined_symbols = StringHashMap(void).init(owner.allocator),
.output_path_source = GeneratedFile{ .step = &self.step },

3
lib/std/Build/InstallArtifactStep.zig
View File

@ -17,8 +17,6 @@ h_dir: ?InstallDir,
dest_sub_path: ?[]const u8,
pub fn create(owner: *std.Build, artifact: *CompileStep) *InstallArtifactStep {
if (artifact.install_step) |s| return s;
const self = owner.allocator.create(InstallArtifactStep) catch @panic("OOM");
self.* = InstallArtifactStep{
.step = Step.init(.{
@ -44,7 +42,6 @@ pub fn create(owner: *std.Build, artifact: *CompileStep) *InstallArtifactStep {
.dest_sub_path = null,
};
self.step.dependOn(&artifact.step);
artifact.install_step = self;
owner.pushInstalledFile(self.dest_dir, artifact.out_filename);
if (self.artifact.isDynamicLibrary()) {