mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-13 04:48:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

crypto.sign.ecdsa: fix toCompressedSec1()/toUnompressedSec1() (#12009)

Browse Source 
The Ecdsa.PublicKey type is not a direct alias for a curve element.

So, use the inner field containing the curve element for serialization.
This commit is contained in:
Frank Denis 2022-07-06 08:30:43 +02:00 committed by GitHub
parent 6279a1d684
commit 38096960fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lib/std/crypto/ecdsa.zig
View File

@ -62,13 +62,13 @@ pub fn Ecdsa(comptime Curve: type, comptime Hash: type) type {
}
/// Encode the public key using the compressed SEC-1 format.
pub fn toCompressedSec1(p: Curve) [compressed_sec1_encoded_length]u8 {
return p.toCompressedSec1();
pub fn toCompressedSec1(pk: PublicKey) [compressed_sec1_encoded_length]u8 {
return pk.p.toCompressedSec1();
}
/// Encoding the public key using the uncompressed SEC-1 format.
pub fn toUncompressedSec1(p: Curve) [uncompressed_sec1_encoded_length]u8 {
return p.toUncompressedSec1();
pub fn toUncompressedSec1(pk: PublicKey) [uncompressed_sec1_encoded_length]u8 {
return pk.p.toUncompressedSec1();
}
};
@ -743,3 +743,15 @@ fn tvTry(vector: TestVector) !void {
const sig = try Scheme.Signature.fromDer(sig_der);
try sig.verify(msg, pk);
}
test "ECDSA - Sec1 encoding/decoding" {
const Scheme = EcdsaP384Sha384;
const kp = try Scheme.KeyPair.create(null);
const pk = kp.public_key;
const pk_compressed_sec1 = pk.toCompressedSec1();
const pk_recovered1 = try Scheme.PublicKey.fromSec1(&pk_compressed_sec1);
try testing.expectEqualSlices(u8, &pk_recovered1.toCompressedSec1(), &pk_compressed_sec1);
const pk_uncompressed_sec1 = pk.toUncompressedSec1();
const pk_recovered2 = try Scheme.PublicKey.fromSec1(&pk_uncompressed_sec1);
try testing.expectEqualSlices(u8, &pk_recovered2.toUncompressedSec1(), &pk_uncompressed_sec1);
}