mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-06 06:13:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

sema: do checked cast when resolving aggregate size

Browse Source
This commit is contained in:
dweiller 2025-04-09 14:25:37 +10:00 committed by Matthew Lugg
parent 1f6336794b
commit 365ed0ed68
2 changed files with 49 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/Sema.zig
View File

@ -34985,7 +34985,15 @@ pub fn resolveStructLayout(sema: *Sema, ty: Type) SemaError!void {
offsets[i] = @intCast(aligns[i].forward(offset));
offset = offsets[i] + sizes[i];
}
struct_type.setLayoutResolved(ip, @intCast(big_align.forward(offset)), big_align);
const size = std.math.cast(u32, big_align.forward(offset)) orelse {
const msg = try sema.errMsg(
ty.srcLoc(zcu),
"struct layout requires size {d}, this compiler implementation supports up to {d}",
.{ big_align.forward(offset), std.math.maxInt(u32) },
);
return sema.failWithOwnedErrorMsg(null, msg);
};
struct_type.setLayoutResolved(ip, size, big_align);
_ = try ty.comptimeOnlySema(pt);
}
@ -35260,7 +35268,15 @@ pub fn resolveUnionLayout(sema: *Sema, ty: Type) SemaError!void {
break :layout .{ size, max_align.max(tag_align), padding };
} else .{ max_align.forward(max_size), max_align, 0 };
union_type.setHaveLayout(ip, @intCast(size), padding, alignment);
const casted_size = std.math.cast(u32, size) orelse {
const msg = try sema.errMsg(
ty.srcLoc(pt.zcu),
"union layout requires size {d}, this compiler implementation supports up to {d}",
.{ size, std.math.maxInt(u32) },
);
return sema.failWithOwnedErrorMsg(null, msg);
};
union_type.setHaveLayout(ip, casted_size, padding, alignment);
if (union_type.flagsUnordered(ip).assumed_runtime_bits and !(try ty.hasRuntimeBitsSema(pt))) {
const msg = try sema.errMsg(

31
test/cases/compile_errors/aggregate_too_large.zig Normal file
View File

@ -0,0 +1,31 @@
const S = struct {
data: [1 << 32]u8,
};
const T = struct {
d1: [1 << 31]u8,
d2: [1 << 31]u8,
};
const U = union {
a: u32,
b: [1 << 32]u8,
};
const V = union {
a: u32,
b: T,
};
comptime {
_ = S;
_ = T;
_ = U;
_ = V;
}
// error
//
// :1:11: error: struct layout requires size 4294967296, this compiler implementation supports up to 4294967295
// :5:11: error: struct layout requires size 4294967296, this compiler implementation supports up to 4294967295
// :10:11: error: union layout requires size 4294967300, this compiler implementation supports up to 4294967295