From 35c694d614c8687ffa99ac187e60d831f9d7f29d Mon Sep 17 00:00:00 2001
From: Evan Haas <evan@lagerdata.com>
Date: Mon, 17 May 2021 15:57:54 -0700
Subject: [PATCH] translate-c: Demote initialization of opaque types

This fixes a segfault in translate-c that would previously occur when
initializing structs with unnamed bitfields, due to a failed assertion in
`transInitListExprRecord`. Unnamed bitfields do not have initializers,
so `transInitListExprRecord` erroneously assumes that `init_count` equals
the number of fields in the record.

Since attempting to initialize an opaque type is a syntax error in Zig,
we can just demote any attempts to initialize them.
---
 src/translate_c.zig  |  4 ++++
 test/translate_c.zig | 16 ++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/src/translate_c.zig b/src/translate_c.zig
index 19aec279ec..2af91f992f 100644
--- a/src/translate_c.zig
+++ b/src/translate_c.zig
@@ -2445,6 +2445,10 @@ fn transInitListExpr(
     var qual_type = qt.getTypePtr();
     const source_loc = @ptrCast(*const clang.Expr, expr).getBeginLoc();
 
+    if (qualTypeWasDemotedToOpaque(c, qt)) {
+        return fail(c, error.UnsupportedTranslation, source_loc, "Cannot initialize opaque type", .{});
+    }
+
     if (qual_type.isRecordType()) {
         return maybeSuppressResult(c, scope, used, try transInitListExprRecord(
             c,
diff --git a/test/translate_c.zig b/test/translate_c.zig
index 5918dbb37b..2647c712b9 100644
--- a/test/translate_c.zig
+++ b/test/translate_c.zig
@@ -3513,4 +3513,20 @@ pub fn addCases(cases: *tests.TranslateCContext) void {
        \\    asm (".globl func\n\t.type func, @function\n\tfunc:\n\t.cfi_startproc\n\tmovl $42, %eax\n\tret\n\t.cfi_endproc");
        \\}
     });
+
+    cases.add("Demote function that initializes opaque struct",
+        \\struct my_struct {
+        \\    unsigned a: 15;
+        \\    unsigned: 2;
+        \\    unsigned b: 15;
+        \\};
+        \\void initialize(void) {
+        \\    struct my_struct S = {.a = 1, .b = 2};
+        \\}
+    , &[_][]const u8{
+        \\warning: Cannot initialize opaque type
+        ,
+        \\warning: unable to translate function, demoted to extern
+        \\pub extern fn initialize() void;
+    });
 }