From 3dbe376c776ce67720ba2ccc9220386b380d5e2f Mon Sep 17 00:00:00 2001 From: Jakub Konka Date: Thu, 28 May 2020 23:32:17 +0200 Subject: [PATCH 1/2] Link issue to the failing test case targeting wasm --- lib/std/fmt.zig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/std/fmt.zig b/lib/std/fmt.zig index b9ee9f797a..4b397e9671 100644 --- a/lib/std/fmt.zig +++ b/lib/std/fmt.zig @@ -1708,14 +1708,15 @@ test "vector" { return error.SkipZigTest; } if (builtin.arch != .wasm32) { - // TODO investigate why this fails on wasm32 - const vbool: std.meta.Vector(4, bool) = [_]bool{ true, false, true, false }; - try testFmt("{ true, false, true, false }", "{}", .{vbool}); + // https://github.com/ziglang/zig/issues/5339 + return error.SkipZigTest; } + const vbool: std.meta.Vector(4, bool) = [_]bool{ true, false, true, false }; const vi64: std.meta.Vector(4, i64) = [_]i64{ -2, -1, 0, 1 }; const vu64: std.meta.Vector(4, u64) = [_]u64{ 1000, 2000, 3000, 4000 }; + try testFmt("{ true, false, true, false }", "{}", .{vbool}); try testFmt("{ -2, -1, 0, 1 }", "{}", .{vi64}); try testFmt("{ - 2, - 1, + 0, + 1 }", "{d:5}", .{vi64}); try testFmt("{ 1000, 2000, 3000, 4000 }", "{}", .{vu64}); From 4f24ab9cfca8a94e3ae7e4269fb8306059ac38cd Mon Sep 17 00:00:00 2001 From: Jakub Konka Date: Fri, 29 May 2020 00:06:26 +0200 Subject: [PATCH 2/2] Fix skipping condition (skip when wasm32) --- lib/std/fmt.zig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/std/fmt.zig b/lib/std/fmt.zig index 4b397e9671..671f25a943 100644 --- a/lib/std/fmt.zig +++ b/lib/std/fmt.zig @@ -1707,7 +1707,7 @@ test "vector" { // https://github.com/ziglang/zig/issues/4486 return error.SkipZigTest; } - if (builtin.arch != .wasm32) { + if (builtin.arch == .wasm32) { // https://github.com/ziglang/zig/issues/5339 return error.SkipZigTest; }