mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-06 06:13:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

spirv: do not decorate nav alignment

Browse Source 
they seem to be always `null` even when accessed through extern key so we have no way to tell whether they have natural alignment or not to decorate. And the reason we don't always decorate them is because some environments might be too dumb and crash for this.
This commit is contained in:
Ali Cheraghi 2025-08-15 19:36:15 +03:30 committed by Andrew Kelley
parent cf90a5e451
commit 2f422372b5
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/codegen/spirv/CodeGen.zig
View File

@ -254,13 +254,7 @@ pub fn genNav(cg: *CodeGen, do_codegen: bool) Error!void {
try cg.module.debugName(func_result_id, nav.fqn.toSlice(ip));
},
.global => {
const maybe_init_val: ?Value = switch (ip.indexToKey(val.toIntern())) {
.func => unreachable,
.variable => |variable| .fromInterned(variable.init),
.@"extern" => null,
else => val,
};
assert(maybe_init_val == null); // TODO
assert(ip.indexToKey(val.toIntern()) == .@"extern");
const storage_class = cg.module.storageClass(nav.getAddrspace());
assert(storage_class != .generic); // These should be instance globals
@ -274,13 +268,6 @@ pub fn genNav(cg: *CodeGen, do_codegen: bool) Error!void {
.storage_class = storage_class,
});
if (nav.getAlignment() != ty.abiAlignment(zcu)) {
if (target.os.tag != .opencl) return cg.fail("cannot apply alignment to variables", .{});
try cg.module.decorate(result_id, .{
.alignment = .{ .alignment = @intCast(nav.getAlignment().toByteUnits().?) },
});
}
switch (target.os.tag) {
.vulkan, .opengl => {
if (ty.zigTypeTag(zcu) == .@"struct") {